linux-kernel - Re: [PATCH 1/1] mm/zswap.c: add lock helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140502182158.GC13207@mguzik.redhat.com>
Date:	Fri, 2 May 2014 20:22:00 +0200
From:	Mateusz Guzik <mguzik@...hat.com>
To:	Fabian Frederick <fabf@...net.be>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Seth Jennings <sjenning@...ux.vnet.ibm.com>,
	akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/1] mm/zswap.c: add lock helper

On Fri, May 02, 2014 at 06:35:10PM +0200, Fabian Frederick wrote:
> &tree->lock is used all over the place
> 
[..]
> +	spinlock_t *lock = &tree->lock;
>  
>  	if (!tree)
>  		return;
>  

Rather fishy, although I'm unsure if this is a real problem.

-- 
Mateusz Guzik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/