linux-kernel - Re: [patch] staging: rtl8723au: fix some confusing indenting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <wrfjvbtmpo24.fsf@ultrasam.lan.trained-monkey.org>
Date:	Sat, 03 May 2014 23:09:07 +0200
From:	Jes Sorensen <Jes.Sorensen@...hat.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Larry Finger <Larry.Finger@...inger.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-wireless@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] staging: rtl8723au: fix some confusing indenting

Dan Carpenter <dan.carpenter@...cle.com> writes:
> The break and the "unknown++" are at the same indent level so my static
> checker complains.  The if statement should be indented more.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Urgh yes, that should be cleaned up!

Acked-by: Jes Sorensen <Jes.Sorensen@...hat.com>

>
> diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> index eb7b98e..4ad80e7 100644
> --- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> +++ b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
> @@ -1235,8 +1235,8 @@ static int rtw_validate_frame_ies(const u8 *start, uint len)
>  		case WLAN_EID_ERP_INFO:
>  		case WLAN_EID_EXT_SUPP_RATES:
>  		case WLAN_EID_VENDOR_SPECIFIC:
> -		if (rtw_validate_vendor_specific_ies(pos, elen))
> -			unknown++;
> +			if (rtw_validate_vendor_specific_ies(pos, elen))
> +				unknown++;
>  			break;
>  		case WLAN_EID_RSN:
>  		case WLAN_EID_PWR_CAPABILITY:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/