linux-kernel - Re: [PATCH v2] staging: rtl8188eu: fix potential leak in rtw_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140504002414.GA10375@kroah.com>
Date:	Sat, 3 May 2014 20:24:14 -0400
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Christian Engelmayer <cengelma@....at>
Cc:	devel@...verdev.osuosl.org, mcgrof@...not-panic.com,
	linux-kernel@...r.kernel.org, oat.elena@...il.com,
	dan.carpenter@...cle.com, Larry.Finger@...inger.net
Subject: Re: [PATCH v2] staging: rtl8188eu: fix potential leak in
 rtw_set_key()

On Thu, May 01, 2014 at 12:30:57PM +0200, Christian Engelmayer wrote:
> Fix a potential leak in the error path of rtw_set_key(). In case the requested
> algorithm is not supported by the driver, the function returns without
> enqueuing or freeing the already allocated command and parameter structs. Use
> a centralized exit path and make sure that all memory is freed correctly.
> Detected by Coverity - CID 1077716, 1077717.
> 
> Signed-off-by: Christian Engelmayer <cengelma@....at>
> Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> v2: Added changes requested by Dan Carpenter:
> 
>    * Just return directly where no cleanup is needed.
>    * Prefer naming labels by the labeled action rather than the goto location.
> 
> Compile tested and applies against branch staging-next of tree
> git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git

This patch doesn't apply to my tree, can you refresh and resend it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/