lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 5 May 2014 06:51:16 -0400 From: Jeff Layton <jlayton@...chiereds.net> To: Fabian Frederick <fabf@...net.be> Cc: linux-kernel <linux-kernel@...r.kernel.org>, akpm <akpm@...ux-foundation.org>, Steve French <sfrench@...ba.org>, linux-cifs <linux-cifs@...r.kernel.org> Subject: Re: [PATCH 1/1] FS/CIFS: remove obsolete __constant On Mon, 5 May 2014 06:53:01 +0200 Fabian Frederick <fabf@...net.be> wrote: > On Sun, 4 May 2014 18:52:43 -0400 > Jeff Layton <jlayton@...chiereds.net> wrote: > > > On Sat, May 3, 2014 at 4:15 PM, Fabian Frederick <fabf@...net.be> wrote: > > > Replacing all __constant_foo to foo() > > > except in smb2status.h (1700 lines to update). > > > > > > Cc: linux-cifs@...r.kernel.org > > > Cc: Steve French <sfrench@...ba.org> > > > Cc: Andrew Morton <akpm@...ux-foundation.org> > > > Signed-off-by: Fabian Frederick <fabf@...net.be> > > > --- > > > fs/cifs/cifsacl.c | 2 +- > > > fs/cifs/cifssmb.c | 20 ++++++++++---------- > > > fs/cifs/sess.c | 2 +- > > > fs/cifs/smb2misc.c | 38 +++++++++++++++++++------------------- > > > fs/cifs/smb2ops.c | 2 +- > > > fs/cifs/smb2pdu.c | 2 +- > > > fs/cifs/smb2pdu.h | 28 ++++++++++++++-------------- > > > 7 files changed, 47 insertions(+), 47 deletions(-) > > > > > > diff --git a/fs/cifs/cifsacl.c b/fs/cifs/cifsacl.c > > > index 7ff866d..54ac0e8 100644 > > > --- a/fs/cifs/cifsacl.c > > > +++ b/fs/cifs/cifsacl.c > > > @@ -38,7 +38,7 @@ static const struct cifs_sid sid_everyone = { > > > 1, 1, {0, 0, 0, 0, 0, 1}, {0} }; > > > /* security id for Authenticated Users system group */ > > > static const struct cifs_sid sid_authusers = { > > > - 1, 1, {0, 0, 0, 0, 0, 5}, {__constant_cpu_to_le32(11)} }; > > > + 1, 1, {0, 0, 0, 0, 0, 5}, {cpu_to_le32(11)} }; > > > > > > Does the build still work on BE arches with this? I know at one point > > the above wouldn't compile on those > > arches. See commit 536abdb0802f, for an explanation. > > Untested on BE but it would mean checkpatch > "don't use __constant<foo> functions outside of include/uapi/" stuff is wrong ? I'm not sure. Maybe the macros have been fixed so that it's no longer a problem? I think it would be good to test build this on a BE arch before it's merged to be certain though. IIRC, I originally saw the problem on s390 builds. -- Jeff Layton <jlayton@...chiereds.net> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists