linux-kernel - Re: [PATCH] misc: genwqe: Fix format string mismatch in card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 05 May 2014 16:21:16 +0200
From:	Frank Haverkamp <haver@...ux.vnet.ibm.com>
To:	Masanari Iida <standby24x7@...il.com>
Cc:	arnd@...db.de, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc: genwqe: Fix format string mismatch in
 card_debugfs.c

Am Donnerstag, den 24.04.2014, 12:25 +0900 schrieb Masanari Iida:
> Fix two format string mismatch in genwqe_init_debugfs()
> 
> Signed-off-by: Masanari Iida <standby24x7@...il.com>
> ---
>  drivers/misc/genwqe/card_debugfs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/genwqe/card_debugfs.c b/drivers/misc/genwqe/card_debugfs.c
> index 50d2096..0a33ade 100644
> --- a/drivers/misc/genwqe/card_debugfs.c
> +++ b/drivers/misc/genwqe/card_debugfs.c
> @@ -348,7 +348,7 @@ int genwqe_init_debugfs(struct genwqe_dev *cd)
>  	char name[64];
>  	unsigned int i;
> 
> -	sprintf(card_name, "%s%u_card", GENWQE_DEVNAME, cd->card_idx);
> +	sprintf(card_name, "%s%d_card", GENWQE_DEVNAME, cd->card_idx);
> 
>  	root = debugfs_create_dir(card_name, cd->debugfs_genwqe);
>  	if (!root) {
> @@ -454,7 +454,7 @@ int genwqe_init_debugfs(struct genwqe_dev *cd)
>  	}
> 
>  	for (i = 0; i <  GENWQE_MAX_VFS; i++) {
> -		sprintf(name, "vf%d_jobtimeout_msec", i);
> +		sprintf(name, "vf%u_jobtimeout_msec", i);
> 
>  		file = debugfs_create_u32(name, 0666, root,
>  					  &cd->vf_jobtimeout_msec[i]);

Thanks for contributing the fix for our driver. I do not see that this
would ever be able to cause a problem. Or do I oversee something?
Regardless of that it appears to looks nicer.

Acked-by: Frank Haverkamp <haver@...ux.vnet.ibm.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/