linux-kernel - Re: [PATCH] plist: include -DDEBUG if CONFIG_DEBUG_PI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 5 May 2014 10:35:01 -0400
From:	Dan Streetman <ddstreet@...e.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] plist: include -DDEBUG if CONFIG_DEBUG_PI_LIST

On Fri, May 2, 2014 at 4:41 PM, Steven Rostedt <rostedt@...dmis.org> wrote:
> On Fri,  2 May 2014 16:23:43 -0400
> Dan Streetman <ddstreet@...e.org> wrote:
>
>> lib/plist.c uses pr_debug() in its test function, which is compiled
>> and run only when CONFIG_DEBUG_PI_LIST in set; however pr_debug()
>> is compiled out unless -DDEBUG is set for the file.
>>
>> Update lib/Makefile to add -DDEBUG to CFLAGS_plist.o if
>> CONFIG_DEBUG_PI_LIST is set, so that the pr_debug() output from
>> plist_test() is shown.
>
> Why not just use printk(KERN_DEBUG ...) then if we always want to print
> it?
>
> You could just place
>
> #define DEBUG
>
> in plist.c as well. Although I think just switching to printk() is
> better.

Agreed - since the entire function is already inside
CONFIG_DEBUG_PI_LIST, there's no need to additionally require DEBUG so
we should just use printk.  New patch to follow.

Thanks!

>
> -- Steve
>
>>
>> Signed-off-by: Dan Streetman <ddstreet@...e.org>
>> ---
>>  lib/Makefile | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/lib/Makefile b/lib/Makefile
>> index 0cd7b68..fd1f4c8 100644
>> --- a/lib/Makefile
>> +++ b/lib/Makefile
>> @@ -39,6 +39,10 @@ CFLAGS_kobject.o += -DDEBUG
>>  CFLAGS_kobject_uevent.o += -DDEBUG
>>  endif
>>
>> +ifeq ($(CONFIG_DEBUG_PI_LIST),y)
>> +CFLAGS_plist.o += -DDEBUG
>> +endif
>> +
>>  obj-$(CONFIG_GENERIC_IOMAP) += iomap.o
>>  obj-$(CONFIG_GENERIC_PCI_IOMAP) += pci_iomap.o
>>  obj-$(CONFIG_HAS_IOMEM) += iomap_copy.o devres.o
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/