linux-kernel - Re: [PATCH 1/5] firmware: Simplify directory creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 05 May 2014 16:52:26 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	Sam Ravnborg <sam@...nborg.org>
CC:	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH 1/5] firmware: Simplify directory creation

On 2014-04-30 18:12, Sam Ravnborg wrote:
> On Tue, Apr 29, 2014 at 04:08:09PM +0200, Michal Marek wrote:
>> When building the firmware blobs, use a simple loop to create
>> directories in $(objtree), like in Makefile.build. This simplifies the
>> rules and also makes it possible to set $(objtree) to '.' later. Before
>> this change, a dependency on $(objtree)/<dir> would be satisfied by
>> <dir> in $(srctree).
>>
>> When installing the firmware blobs, call mkdir like in Makefile.modinst.
>>
>> Cc: David Woodhouse <dwmw2@...radead.org>
>> Signed-off-by: Michal Marek <mmarek@...e.cz>
> 
> Hi Michal.
> 
> The patch looks good. I di not stare enough to fully grasp it,
> but it is a nice cleanup.

Previously, there were make rules for

$(objtree)/firmware/<dir>

to create each <dir> under firmware. If we change $(objtree) to '.', the
rule becomes ./firmware/<dir>, but since there already is
$(srctree)/firmware/<dir> and VPATH is set to $(srctree), the rule will
be satisfied by the directory in the $(srctree) and no directory in
$(objtree) will be created. So I changed it to create the directories
unconditionally when parsing the Makefile, just like
scripts/Makefile.build does it.

Michal

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/