[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 5 May 2014 17:45:59 +0200
From: Oleg Nesterov <oleg@...hat.com>
To: Denys Vlasenko <dvlasenk@...hat.com>
Cc: linux-kernel@...r.kernel.org, Jim Keniston <jkenisto@...ibm.com>,
Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH v2] uprobes: fix scratch register selection for
rip-relative fixups
On 05/02, Denys Vlasenko wrote:
>
> v2: More robust checks of vex.vvvv (32-bit mode safe),
> simplified scratch reg selection code,
> moved comments around as requested by Oleg.
OK, thanks. Given that this patch was acked by Jim, I am going to
apply it. I'll try to run a couple of systemtap scripts with this
patch, but unfortunately the "full" testing is simply impossible.
Denys, I'll also include your test-case into the changelog.
And,
> static inline unsigned long *
> scratch_reg(struct arch_uprobe *auprobe, struct pt_regs *regs)
> {
> - return (auprobe->def.fixups & UPROBE_FIX_RIP_AX) ? ®s->ax : ®s->cx;
> + /* Order is important - more than one bit can be set! */
Really?
Should I remove this comment or I misread the change in riprel_analyze?
Oleg.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists