linux-kernel - Re: [PATCH] staging: vt6655: correct coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 5 May 2014 21:16:03 +0200
From:	Clément Calmels <clement.calmels@...e.fr>
To:	Greg KH <greg@...ah.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vt6655: correct coding style issue

On Sun, 4 May 2014 17:26:58 -0400
Greg KH <greg@...ah.com> wrote:

> On Sun, May 04, 2014 at 09:52:09PM +0200, Clément Calmels wrote:
> > Remove C99 comment and rewrite lines over 80 characters.
> > Warnings and error found by checkpatch.pl script.
> > 
> > Signed-off-by: Clément Calmels <clement.calmels@...e.fr>
> > ---
> >  drivers/staging/vt6655/tmacro.h | 13 +++++++++----
> >  1 file changed, 9 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/staging/vt6655/tmacro.h
> > b/drivers/staging/vt6655/tmacro.h index 59c6e72..264c6ed 100644
> > --- a/drivers/staging/vt6655/tmacro.h
> > +++ b/drivers/staging/vt6655/tmacro.h
> > @@ -44,17 +44,22 @@
> >  #define LOWORD(d)           ((unsigned short)(d))
> >  #endif
> >  #if !defined(HIWORD)
> > -#define HIWORD(d)           ((unsigned short)((((unsigned
> > long)(d)) >> 16) & 0xFFFF)) +#define
> > HIWORD(d)							\
> > +	((unsigned short)((((unsigned long)(d)) >> 16) & 0xFFFF))
> >  #endif
> >  
> >  #define LODWORD(q)          ((q).u.dwLowDword)
> >  #define HIDWORD(q)          ((q).u.dwHighDword)
> >  
> >  #if !defined(MAKEWORD)
> > -#define MAKEWORD(lb, hb)    ((unsigned short)(((unsigned
> > char)(lb)) | (((unsigned short)((unsigned char)(hb))) << 8)))
> > +#define MAKEWORD(lb, hb)\
> > +	((unsigned short)(((unsigned
> > char)(lb))				\
> > +			  | (((unsigned short)((unsigned
> > char)(hb))) << 8))) #endif
> >  #if !defined(MAKEDWORD)
> > -#define MAKEDWORD(lw, hw)   ((unsigned long)(((unsigned
> > short)(lw)) | (((unsigned long)((unsigned short)(hw))) << 16)))
> > +#define MAKEDWORD(lw, hw)\
> > +	((unsigned long)(((unsigned
> > short)(lw))				\
> > +			 | (((unsigned long)((unsigned
> > short)(hw))) << 16))) #endif
> >  
> > -#endif // __TMACRO_H__
> > +#endif /* __TMACRO_H__ */
> 
> Why not just switch to use the built-in macros the kernel provides for
> this?
> 
> greg k-h

Are you talking about changing types (unsigned char => u8) as used
there:
http://lxr.free-electrons.com/source/sound/isa/msnd/msnd.h#L182 or
there:
http://lxr.free-electrons.com/source/include/acpi/actypes.h#L481 ?

C.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/