linux-kernel - Re: [PATCH] net: macb: set interface name based on DT aliases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 5 May 2014 13:40:22 -0700
From:	Olof Johansson <olof@...om.net>
To:	Boris BREZILLON <brezillonboris@...il.com>
Cc:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Arnd Bergmann <arnd@...db.de>,
	linux-arm-kernel@...ts.infradead.org, arm@...nel.org,
	linux-kernel@...r.kernel.org,
	Boris BREZILLON <b.brezillon.dev@...il.com>
Subject: Re: [PATCH] net: macb: set interface name based on DT aliases

On Wed, Mar 12, 2014 at 11:29:56AM +0100, Boris BREZILLON wrote:
> Use aliases to set the interface name (ethX) instead of automatic
> assignement.
> 
> Signed-off-by: Boris BREZILLON <b.brezillon.dev@...il.com>
> ---
> 
> Hello Nicolas, Jean-Christophe,
> 
> This is an example on how we could set the ethernet interface id based on DT
> aliases.
> As you can see this patch is not properly separated.
> 
> I'm still not happy with this approach for several reasons:
> 1) If another ethernet iface has already been registered with the same id the
>    net dev registration will fail.
> 2) We bypass the ethernet macros/functions and directly use the net device
>    functions which IMHO is not future proof.

[Sorry for the late reply, going through old backlog of unread email]

Looks like this should live in networking core instead of in the driver, it's
how we handle it in other subsystems.

I don't know what DaveM's opinions on that is though.


-Olof

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/