linux-kernel - Re: [PATCH 02/27] ACPICA: Utilities: Deploy ACPI_DEBUGGER_EXEC for ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140506075353.GA20931@xo-6d-61-c0.localdomain>
Date:	Tue, 6 May 2014 09:53:53 +0200
From:	Pavel Machek <pavel@....cz>
To:	Lv Zheng <lv.zheng@...el.com>
Cc:	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Len Brown <len.brown@...el.com>, Lv Zheng <zetalog@...il.com>,
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
	Bob Moore <robert.moore@...el.com>
Subject: Re: [PATCH 02/27] ACPICA: Utilities: Deploy ACPI_DEBUGGER_EXEC for
 ACPI_DEBUGGER enabled code in utglobal.c.

On Wed 2014-04-30 10:03:39, Lv Zheng wrote:
> This patch deploys ACPI_DEBUGGER_EXEC usage to utglobal.c to reduce "ifdef"
> of ACPI_DEBUGGER.  No functional changes.  Lv Zheng.
> 
> Signed-off-by: Lv Zheng <lv.zheng@...el.com>
> Signed-off-by: Bob Moore <robert.moore@...el.com>
> ---
>  drivers/acpi/acpica/utglobal.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/acpi/acpica/utglobal.c b/drivers/acpi/acpica/utglobal.c
> index f3abeae..825b064 100644
> --- a/drivers/acpi/acpica/utglobal.c
> +++ b/drivers/acpi/acpica/utglobal.c
> @@ -377,9 +377,7 @@ acpi_status acpi_ut_init_globals(void)
>  	acpi_gbl_disable_mem_tracking = FALSE;
>  #endif
>  
> -#ifdef ACPI_DEBUGGER
> -	acpi_gbl_db_terminate_threads = FALSE;
> -#endif
> +	ACPI_DEBUGGER_EXEC(acpi_gbl_db_terminate_threads = FALSE);
>  
>  	return_ACPI_STATUS(AE_OK);

Is it just me or is this incredibly ugly?

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/