linux-kernel - Re: [RFC PATCH 0/2] kpatch: dynamic kernel patching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140506121714.GB4125@treble.redhat.com>
Date:	Tue, 6 May 2014 07:17:14 -0500
From:	Josh Poimboeuf <jpoimboe@...hat.com>
To:	David Lang <david@...g.hm>
Cc:	Jiri Kosina <jkosina@...e.cz>, Seth Jennings <sjenning@...hat.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>, Jiri Slaby <jslaby@...e.cz>,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 0/2] kpatch: dynamic kernel patching

On Mon, May 05, 2014 at 06:59:29PM -0700, David Lang wrote:
> On Tue, 6 May 2014, Jiri Kosina wrote:
> 
> >On Mon, 5 May 2014, David Lang wrote:
> >
> >>how would you know that all instances of the datastructure in memory
> >>have= been touched? just because all tasks have run and are outside the
> >>function in question doesn't tell you data structures have been
> >>converted. You have n= o way of knowing when (or if) the next call to
> >>the modified function will take place on any potential in-memory
> >>structure.
> >
> >The problem you are trying to avoid here is functions expecting to read
> >"v2" format of the data from memory, while there are still tasks that are
> >unpredictably writing "v1" format of the data to the memory.
> >
> >There are several ways to attack this problem:
> >
> >- stop the whole system, convert all the existing data structures to new
> > format (which might potentially be non-trivial, mostly because you
> > have to *know* where all the data structures have been allocated), apply
> > patch, resume operation [ksplice, probably kpatch in future]
> >- restrict the data format to be backwards compatible [to be done
> > manually during patch creation, currently what kGraft needs to do in
> > such case]
> >- have a proxy code which can read both "v1" and "v2" formats, and writes
> > back in the same format it has seen the data structure on input
> 
> doesn't this have the same problem of finding all the data?
> 
> >- once all the *code* has been converted, it still has to understand "v1"
> > and "v2", but it can now start writing out "v2" format only [possible
> > with kGraft, not implemented in automated fashion]
> 
> which is a varient of the second one in that all the data needs to be tagged
> with a version so that it can be converted.
> 
> I don't see that 'stop the world' ends up being much better for this.
> 
> it does avoid any possibility of v1 code reading v2 data, but it doesn't
> help in avoiding v2 code reading v1 data some time (potentially much) later.

In general we would avoid this type of situation, where data semantics
change.  If it's absolutely necessary, then it's up to the user to write
a hook function that will find all the data structures and convert them
at patch loading time.  If they can't write a function which does that
sufficiently and safely, then live patching isn't a good option.

-- 
Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/