[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4660313.evfclGtT1x@wuerfel>
Date: Tue, 06 May 2014 14:21:55 +0200
From: Arnd Bergmann <arnd@...db.de>
To: linux-arm-kernel@...ts.infradead.org
Cc: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
Lior Amsalem <alior@...vell.com>, Andrew Lunn <andrew@...n.ch>,
linux-usb@...r.kernel.org, Jason Cooper <jason@...edaemon.net>,
Mathias Nyman <mathias.nyman@...el.com>,
devicetree@...r.kernel.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
linux-kernel@...r.kernel.org, Felipe Balbi <balbi@...com>,
Nadav Haklai <nadavh@...vell.com>,
Gregory CLEMENT <gregory.clement@...e-electrons.com>,
Rob Herring <robh+dt@...nel.org>,
Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>,
Grant Likely <grant.likely@...aro.org>,
Tawfik Bayouk <tawfik@...vell.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
Subject: Re: [PATCH v3 06/20] usb: host: xhci-plat: Add support for the Armada 38x
On Tuesday 06 May 2014 14:10:23 Thomas Petazzoni wrote:
> On Tue, 06 May 2014 13:57:44 +0200, Arnd Bergmann wrote:
>
> > > Please limit this driver to mvebu arch and compile testing, i.e.
> > >
> > > depends on ARCH_MVEBU || COMPILE_TEST
> >
> > I think it actually needs a dependency on MVEBU_MBUS.
>
> That's not what we do for any of the other drivers that use the
> MVEBU_MBUS functions.
Fair enough. I guess using ARCH_MVEBU as the dependency works as well
because it implies MVEBU_MBUS. However, you can't use COMPILE_TEST
then because the driver itself needs the interfaces provided by MBUS.
It could be
depends on ARCH_MVEBU || (MVEBU_MBUS && COMPILE_TEST)
to describe the dependency most accurately.
> > You probably need something like
> >
> > depends on MVEBU_MBUS=y || (MVEBU_MBUS=m && USB_XHCI=m)
>
> MVEBU_MBUS is a bool, so there is no way is can be =m.
Yes, that helps.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists