linux-kernel - Re: [PATCH] clk: st: Fix memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5368D645.7030206@st.com>
Date:	Tue, 6 May 2014 14:32:05 +0200
From:	Gabriel Fernandez <gabriel.fernandez@...com>
To:	Valentin Ilie <valentin.ilie@...il.com>,
	Mike Turquette <mturquette@...aro.org>, <pankaj.dev@...com>
Cc:	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clk: st: Fix memory leak

Hi Valentin
Thanks for the patch, i agree with it.

Mike do you planned to integrate this patch ?

Gabriel.

Best Regards.


On 05/06/2014 11:29 AM, Valentin Ilie wrote:
> On 22 April 2014 16:15, Valentin Ilie <valentin.ilie@...il.com> wrote:
>> When it fails to allocate div, gate should be free'd before return
>>
>> Signed-off-by: Valentin Ilie <valentin.ilie@...il.com>
>> ---
>>   drivers/clk/st/clkgen-pll.c | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/clk/st/clkgen-pll.c b/drivers/clk/st/clkgen-pll.c
>> index bca0a0b..a886702 100644
>> --- a/drivers/clk/st/clkgen-pll.c
>> +++ b/drivers/clk/st/clkgen-pll.c
>> @@ -521,8 +521,10 @@ static struct clk * __init clkgen_odf_register(const char *parent_name,
>>          gate->lock = odf_lock;
>>
>>          div = kzalloc(sizeof(*div), GFP_KERNEL);
>> -       if (!div)
>> +       if (!div) {
>> +               kfree(gate);
>>                  return ERR_PTR(-ENOMEM);
>> +       }
>>
>>          div->flags = CLK_DIVIDER_ONE_BASED | CLK_DIVIDER_ALLOW_ZERO;
>>          div->reg = reg + pll_data->odf[odf].offset;
>> --
>> 1.8.3.2
>>
> Can someone look into this?
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/