linux-kernel - Re: [PATCH v2 05/12] ARM: lpc32xx: add MTD_SPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140506171557.GB28907@ld-irv-0074>
Date:	Tue, 6 May 2014 10:15:57 -0700
From:	Brian Norris <computersforpeace@...il.com>
To:	Roland Stigge <stigge@...com.de>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	Huang Shijie <b32955@...escale.com>,
	Marek Vasut <marex@...x.de>, linux-mtd@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 05/12] ARM: lpc32xx: add MTD_SPI_NOR (new dependency
 for M25P80)

On Thu, May 01, 2014 at 07:21:06PM +0200, Roland Stigge wrote:
> On 01/05/14 08:26, Brian Norris wrote:
> > This defconfig contains the CONFIG_M25P80 symbol, which is now
> > dependent on the MTD_SPI_NOR symbol. Add CONFIG_MTD_SPI_NOR to satisfy
> > the new dependency.
> 
> Can't the CONFIG_M25P80 declare its dependency on CONFIG_MTD_SPI_NOR
> itself, or put CONFIG_M25P80 etc. into a submenu under CONFIG_MTD_SPI_NOR?

It does declared the dependency already. And I plan to move it under the
SPI-NOR submenu too.

But as I stated in the cover letter (I'm not sure if it made it through
to all the cross-posted ML's):

  http://article.gmane.org/gmane.linux.ports.ppc.embedded/69885

  "Note that without the new CONFIG_MTD_SPI_NOR symbol in your
  defconfig, Kconfig will automatically drop M25P80 for you."

So declaring the dependency is half the battle, but you still have to
include your dependencies in your defconfig.

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/