linux-kernel - Re: [PATCH 1/2] uprobes: add comment with insn opcodes, mnemonics and why we dont support them

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140506192641.GA12481@redhat.com>
Date:	Tue, 6 May 2014 21:26:41 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Denys Vlasenko <dvlasenk@...hat.com>
Cc:	linux-kernel@...r.kernel.org, Jim Keniston <jkenisto@...ibm.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH 1/2] uprobes: add comment with insn opcodes, mnemonics
	and why we dont support them

Firstly, let me remind that my understanding of low lovel hardware details
is very limited.

On 05/06, Denys Vlasenko wrote:
>
> Oleg, can you clear for me the following -
>
> If the probed instruction triggers an "illegal insn" or "privileged insn"
> CPU exception - are we completely fine?

Yes I think we are fine. I assume that, say, do_debug() won't be called in this
case, and do_invalid_op()->do_trap() should trigger arch_uprobe_xol_was_trapped()
logic.

Well, actually we are not 100% fine because si_addr can be wrong. But this is
not invalid_op-specific, we need to fix this anyway and the fix is simple.

I do not want to discuss this now, but I am going to make another series later
which adds something like uprobe_instruction_pointer(regs). It can (should) be
used by DO_ERROR_INFO() (perhaps by something else, not sure about math_error())
_and_ by show_unhandled_signals users (actually the main reason to me). The only
problem is that this code should be cleanuped first. In fact I was thinking about
this change from the very beginning of the recent fixes, the "wrong" ip reported
by do_general_protection() greatly complicated the investigation of that problem.
But I need to take a rest of uprobes ;)

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/