linux-kernel - Re: [PATCH] staging: binder: fix usage of uninit scalar in binder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 6 May 2014 16:33:35 -0700
From:	Arve Hjønnevåg <arve@...roid.com>
To:	Christian Engelmayer <cengelma@....at>
Cc:	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	John Stultz <john.stultz@...aro.org>,
	Serban Constantinescu <serban.constantinescu@....com>,
	Colin Cross <ccross@...roid.com>,
	Greg KH <gregkh@...uxfoundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: binder: fix usage of uninit scalar in binder_transaction()

On Sat, May 3, 2014 at 4:15 PM, Christian Engelmayer <cengelma@....at> wrote:
> Fix the error path when a cookie mismatch is detected. In that case the
> function jumps to the exit label without setting the uninitialized, local
> variable 'return_error'. Detected by Coverity - CID 201453.
>
> Signed-off-by: Christian Engelmayer <cengelma@....at>
> ---
> Compile tested and applies against branch staging-next of tree
> git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> ---
>  drivers/staging/android/binder.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
> index 1f5e249..ca1b0e3 100644
> --- a/drivers/staging/android/binder.c
> +++ b/drivers/staging/android/binder.c
> @@ -1529,6 +1529,7 @@ static void binder_transaction(struct binder_proc *proc,
>                                         proc->pid, thread->pid,
>                                         (u64)fp->binder, node->debug_id,
>                                         (u64)fp->cookie, (u64)node->cookie);
> +                               return_error = BR_FAILED_REPLY;
>                                 goto err_binder_get_ref_for_node_failed;
>                         }
>                         ref = binder_get_ref_for_node(target_proc, node);
> --
> 1.9.1

Acked-by: Arve Hjønnevåg <arve@...roid.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/