linux-kernel - Re: [PATCH v2] w1: do not unlock unheld list_mutex in __w1_remove_master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1240941399420266@web11m.yandex.ru>
Date:	Wed, 07 May 2014 03:51:06 +0400
From:	zbr@...emap.net
To:	David Fries <david@...es.net>,
	Alexey Khoroshilov <khoroshilov@...ras.ru>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"ldv-project@...uxtesting.org" <ldv-project@...uxtesting.org>
Subject: Re: [PATCH v2] w1: do not unlock unheld list_mutex in __w1_remove_master_device()

Hi everyone

07.05.2014, 03:49, "David Fries" <David@...es.net>:
> Acked-by: David Fries <david@...es.net>
>
> On Wed, May 07, 2014 at 01:26:04AM +0400, Alexey Khoroshilov wrote:
>
>>  w1_process_callbacks() expects to be called with dev->list_mutex held,
>>  but it is the fact only in w1_process(). __w1_remove_master_device()
>>  calls w1_process_callbacks() after it releases list_mutex.
>>
>>  The patch fixes __w1_remove_master_device() to acquire list_mutex
>>  for w1_process_callbacks().
>>
>>  Found by Linux Driver Verification project (linuxtesting.org).
>>
>>  Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>

Thanks for this fix
Acked-by: Evgeniy Polyakov <zbr@...emap.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/