linux-kernel - Re: [PATCH] Staging: android: fix coding style issue in timed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20140507084156.GX26890@mwanda>
Date:	Wed, 7 May 2014 11:41:56 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	John Church <j.church@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, georgiana.chelu93@...il.com,
	waydi1@...il.com
Subject: Re: [PATCH] Staging: android: fix coding style issue in timed_gpio.c

On Wed, May 07, 2014 at 07:23:33AM +0100, John Church wrote:
> This patch fixes a coding style issue. It modifies a single line
> that was over 80 characters long.
> 
> Thanks,
> John

> Signed-off-by: John Church <j.church@...il.com>

This patch isn't sent in the correct way.  Use git send-email or
read Documentation/email-clients.txt.  Send the patch to yourself.
Save it as raw text including headers and everything.
`cat raw_email.txt | git am`.  Review the log with "git log -p".  When
that looks good then resend it to the list.

> 
> --- linux-next/drivers/staging/android/timed_gpio.c.orig	2014-05-07 00:20:50.429090320 +0100
> +++ linux-next/drivers/staging/android/timed_gpio.c	2014-05-07 00:22:09.204795052 +0100
> @@ -92,7 +92,7 @@ static int timed_gpio_probe(struct platf
>  		return -EBUSY;
>  
>  	gpio_data = devm_kzalloc(&pdev->dev,
> -				sizeof(struct timed_gpio_data) * pdata->num_gpios,
> +			sizeof(struct timed_gpio_data) * pdata->num_gpios,
>  				GFP_KERNEL);

To be honest, I prefered the original because everything lined up nicely
in the original.  Now it just looks whacky.

regards,
dan carpenter

>  	if (!gpio_data)
>  		return -ENOMEM;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/