linux-kernel - Re: [PATCH] libata-sff: remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1399454604.6659.13.camel@x220>
Date:	Wed, 07 May 2014 11:23:24 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Alan Cox <alan@...ux.intel.com>
Cc:	David Howells <dhowells@...hat.com>, Tejun Heo <tj@...nel.org>,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] libata-sff: remove dead code

[Added David.]

On Tue, 2014-05-06 at 22:26 +0100, Alan Cox wrote:
> On Sun, 2014-05-04 at 13:50 +0200, Paul Bolle wrote:
> > Ever since v2.6.19 the code contains a check for CONFIG_NO_ATA_LEGACY.
> > But that macro has never been defined. Apparently no one ran into
> > problems on platforms that do not support compatibility mode.
> 
> It was needed for some of the FRV devices I belive. Please check with
> David Howells if it's still relevant

This code has been behind (effectively) an "#if 0" check for seven
years. So either there was no problem to begin with, the problem is
fixed somewhere else, or no one is actually using the affected devices.
So I doubt this is still relevant. But maybe David thinks otherwise...

> (even if its not used in the default configs)

It's not used (and has never been used) regardless which config one
tries.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/