linux-kernel - Re: [PATCH V2] clocksource: register cpu notifier to remove timer from dying CPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 7 May 2014 12:08:53 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Viresh Kumar <viresh.kumar@...aro.org>
cc:	john.stultz@...aro.org, linaro-kernel@...ts.linaro.org,
	linaro-networking@...aro.org, Arvind.Chauhan@....com,
	linux-kernel@...r.kernel.org, fengguang.wu@...el.com,
	jet.chen@...el.com
Subject: Re: [PATCH V2] clocksource: register cpu notifier to remove timer
 from dying CPU

On Wed, 9 Apr 2014, Viresh Kumar wrote:
> This patch tries to fix this by registering cpu notifiers from clocksource core,
> only when we start clocksource-watchdog. And if on the CPU_DEAD notification it
> is found that dying CPU was the CPU on which this timer is queued on, then it is
> removed from that CPU and queued to next CPU.

Gah, no. We realy don't want more notifier crap.
  
It's perfectly fine for the watchdog timer to be moved around on cpu
down. And the timer itself is not pinned at all. add_timer_on() does
not set the pinned bit.

Thanks,

	tglx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/