lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 7 May 2014 14:52:39 +0200 From: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com> To: Andrew Lunn <andrew@...n.ch> Cc: Gregory CLEMENT <gregory.clement@...e-electrons.com>, Mathias Nyman <mathias.nyman@...el.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Felipe Balbi <balbi@...com>, linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org, Jason Cooper <jason@...edaemon.net>, Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>, Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>, linux-arm-kernel@...ts.infradead.org, Lior Amsalem <alior@...vell.com>, Tawfik Bayouk <tawfik@...vell.com>, Nadav Haklai <nadavh@...vell.com>, Grant Likely <grant.likely@...aro.org>, Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org Subject: Re: [PATCH v3 17/20] phy: Add support for USB cluster on the Armada 375 SoC Dear Andrew Lunn, On Tue, 6 May 2014 15:54:27 +0200, Andrew Lunn wrote: > > +enum { > > + PHY_USB2 = 0, > > + PHY_USB3 = 1, > > +}; > > + > > +struct armada375_cluster_phy { > > + struct phy *phy; > > + void __iomem *reg; > > + bool enable; > > + bool use_usb3; > > Hi Gregory > > nit: How about using the enum you just defined? Nope, I don't think it's a good idea, because they mean different things. The enum is used to index the arrays of two PHYs: PHY_USB2 is the first one, PHY_USB3 is the second one. On the other hand, the 'use_usb3' field indicates in which mode is a particular PHY. So it could apply on either of the PHYs, and is therefore not related to the index of the PHYs in the array. > > + usb_cluster_base = of_iomap(np, 0); > > devm_ API? > > Check the return value for an error? Indeed, I'll use devm_ioremap_resource() here. > > + BUG_ON(!usb_cluster_base); > > + > > + for (i = 0; i < NB_PHY; i++) { > > + phy = devm_phy_create(dev, &armada375_usb_phy_ops, NULL); > > + if (IS_ERR(phy)) > > + dev_err(dev, "failed to create PHY n%d\n", i); > > + > > + usb_cluster_phy[i].phy = phy; > > + usb_cluster_phy[i].reg = usb_cluster_base; > > + usb_cluster_phy[i].enable = false; > > + phy_set_drvdata(phy, &usb_cluster_phy[i]); > > + } > > + > > + usb_cluster_phy[PHY_USB2].use_usb3 = false; > > + usb_cluster_phy[PHY_USB3].use_usb3 = true; > > + > > + /* > > + * We can't use the first usb2 unit and usb3 at the same time > > + * to manage a USB2 device, so let's disable usb2 if usb3 is > > + * slelected. In this case USB2 device will be managed by the > > selected Fixed. Thanks, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists