linux-kernel - Re: [PATCH v3] x86/iosf: Make IOSF driver modular and usable by more drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140507195822.2d5dea58@alan.etchedpixels.co.uk>
Date:	Wed, 7 May 2014 19:58:22 +0100
From:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	"David E. Box" <david.e.box@...ux.intel.com>, tglx@...utronix.de,
	mingo@...hat.com, x86@...nel.org, rafael.j.wysocki@...el.com,
	linux-kernel@...r.kernel.org, kristen.c.accardi@...el.com,
	jacob.jun.pan@...ux.intel.com
Subject: Re: [PATCH v3] x86/iosf: Make IOSF driver modular and usable by
 more drivers

> I guess I don't see why the module isn't removable.  Of course, any
> driver which calls iosf_mbi_available() will depend on it, preventing
> removal until *those* modules have been removed...

Going back over the current version you could unload it but you rely upon
the iosf_mbi_available caller locking the module in memory (which I think
is fair) and someone not forcing a hot unplug of any kind from userspace,
in which case life gets a bit odd as we clear mbi_pdev in the exit method
not when the device is unplugged. Probably for the best as with a remove
method you'd need to check the mbi_pdev pointer inside iosf_mbi_lock and
also clear it under the lock.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/