linux-kernel - [tip:perf/kprobes] kprobes: Ensure blacklist data is aligned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-69902c718c0b476e94ed7fccd3cf29ca39fe433a@git.kernel.org>
Date:	Wed, 7 May 2014 12:18:33 -0700
From:	tip-bot for Vineet Gupta <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	mingo@...nel.org, rusty@...tcorp.com.au,
	torvalds@...ux-foundation.org, Vineet.Gupta1@...opsys.com,
	rdunlap@...radead.org, arnd@...db.de, jeremy@...p.org,
	dl9pf@....de, sparse@...isli.org, tglx@...utronix.de,
	linux-kernel@...r.kernel.org, hpa@...or.com,
	Anton.Kolesov@...opsys.com, anil.s.keshavamurthy@...el.com,
	davem@...emloft.net, ananth@...ibm.com, vgupta@...opsys.com,
	masami.hiramatsu.pt@...achi.com, chrisw@...s-sol.org,
	akataria@...are.com
Subject: [tip:perf/kprobes] kprobes: Ensure blacklist data is aligned

Commit-ID:  69902c718c0b476e94ed7fccd3cf29ca39fe433a
Gitweb:     http://git.kernel.org/tip/69902c718c0b476e94ed7fccd3cf29ca39fe433a
Author:     Vineet Gupta <Vineet.Gupta1@...opsys.com>
AuthorDate: Thu, 1 May 2014 10:56:44 +0530
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Wed, 7 May 2014 21:04:57 +0200

kprobes: Ensure blacklist data is aligned

ARC Linux (not supporting native unaligned access) was failing
to boot because __start_kprobe_blacklist was not aligned.

This was because per generated vmlinux.lds it was emitted right
next to .rodata with strings etc hence could be randomly
unaligned.

Fix that by ensuring a word alignment. While 4 would suffice for
32bit arches and problem at hand, it is probably better to put 8.

| Path: (null) CPU: 0 PID: 1 Comm: swapper Not tainted
| 3.15.0-rc3-next-20140430 #2
| task: 8f044000 ti: 8f01e000 task.ti: 8f01e000
|
| [ECR   ]: 0x00230400 => Misaligned r/w from 0x800fb0d3
| [EFA   ]: 0x800fb0d3
| [BLINK ]: do_one_initcall+0x86/0x1bc
| [ERET  ]: init_kprobes+0x52/0x120

Signed-off-by: Vineet Gupta <vgupta@...opsys.com>
Cc: <torvalds@...ux-foundation.org>
Cc: <rusty@...tcorp.com.au>
Cc: <rdunlap@...radead.org>
Cc: <jeremy@...p.org>
Cc: <arnd@...db.de>
Cc: <dl9pf@....de>
Cc: <sparse@...isli.org>
Cc: <anil.s.keshavamurthy@...el.com>
Cc: <davem@...emloft.net>
Cc: <ananth@...ibm.com>
Cc: <masami.hiramatsu.pt@...achi.com>
Cc: <chrisw@...s-sol.org>
Cc: <akataria@...are.com>
Cc: anton Kolesov <Anton.Kolesov@...opsys.com>
Link: http://lkml.kernel.org/r/5361DB14.7010406@synopsys.com
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 include/asm-generic/vmlinux.lds.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
index 40ceb3c..8e0204a 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -110,7 +110,8 @@
 #endif
 
 #ifdef CONFIG_KPROBES
-#define KPROBE_BLACKLIST()	VMLINUX_SYMBOL(__start_kprobe_blacklist) = .; \
+#define KPROBE_BLACKLIST()	. = ALIGN(8);				      \
+				VMLINUX_SYMBOL(__start_kprobe_blacklist) = .; \
 				*(_kprobe_blacklist)			      \
 				VMLINUX_SYMBOL(__stop_kprobe_blacklist) = .;
 #else
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/