linux-kernel - Re: [PATCH] Fixing Coding style Warnings in file drivers/staging/comedi/drivers/das08.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1399491811.6345.3.camel@joe-AO725>
Date:	Wed, 07 May 2014 12:43:31 -0700
From:	Joe Perches <joe@...ches.com>
To:	Sheetal Tigadoli <sheetal.tigadoli@...il.com>
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fixing Coding style Warnings in file
 drivers/staging/comedi/drivers/das08.h

On Tue, 2014-05-06 at 14:54 +0530, Sheetal Tigadoli wrote:
>  This patch fixes coding style warnings such as 'lines exceeding 80 characters limit' & 
>  'lines begining with space character', in file drivers/staging/comedi/drivers/das08.h

This is poor patch subject style.
Please use "[PATCH] subsystem: description" style.

>  This patch is sent to complete one of Eudyptula Challenges

Please do not include any "Eudyptula Challenge" line
in the commit log.

> diff --git a/drivers/staging/comedi/drivers/das08.h b/drivers/staging/comedi/drivers/das08.h
[]
> @@ -50,7 +49,8 @@ struct das08_board_struct {
>  struct i8254_struct {
> -	int channels;		/*  available channels. Some could be used internally. */
> +	int channels;		/*  available channels. Some could be used
> +				    internally. */

Multiline comment style should use
	/*
	 * comment lines
	 * ...
	 */


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/