linux-kernel - Re: [PATCH 0/4] DT platform device name collision fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <536AB91F.3010302@gmail.com>
Date:	Wed, 07 May 2014 15:52:15 -0700
From:	Frank Rowand <frowand.list@...il.com>
To:	Rob Herring <robherring2@...il.com>
CC:	Grant Likely <grant.likely@...aro.org>,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	"Ivan T. Ivanov" <iivanov@...sol.com>,
	Josh Cartwright <joshc@...eaurora.org>,
	Courtney Cavin <courtney.cavin@...ymobile.com>,
	Bjorn Andersson <bjorn@...o.se>, Rob Herring <robh@...nel.org>
Subject: Re: [PATCH 0/4] DT platform device name collision fixes

On 5/7/2014 2:48 PM, Rob Herring wrote:
> From: Rob Herring <robh@...nel.org>
> 
> This series fixes the device naming collisions that can occur with 
> nultiple devices having the same name and non-translatable unit 
> addresses. This issue was raised in this thread[1]. I intend to merge 
> this regardless of whether or not some hierarchy in sysfs is created. 
> That is really a separate issue independent of these fixes.
> 
> I found and fix a couple of other issues in the process of testing the 
> fix.
> 
> Rob
> 
> [1] https://lkml.org/lkml/2014/4/23/312
> 
> Rob Herring (4):
>   of/selftest: add testcase for nodes with same name and address
>   of/platform: return error on of_platform_device_create_pdata failure
>   of/platform: fix device naming for non-translatable addresses
>   of: kill off of_can_translate_address

My opinion is that this approach is not a good approach to solving the
problem.  It is papering over a symptom, instead of dealing with the
root cause.

But despite my opinion, you can add to patches 2-4 (I did not test
the self-test added in patch 1):

   Tested-by: Frank Rowand <frank.rowand@...ymobile.com>

The patches resolve the name conflict originally reported for the
qcomm PMIC, tested on 3.15-rc1, with a bunch of out of tree
patches.

-Frank

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/