linux-kernel - Re: [PATCH v3 2/3] perf record: Propagate exit status of a command line workload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87eh04oglb.fsf@sejong.aot.lge.com>
Date:	Thu, 08 May 2014 16:49:20 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Stephane Eranian <eranian@...gle.com>,
	Jiri Olsa <jolsa@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Namhyung Kim <namhyung.kim@....com>
Subject: Re: [PATCH v3 2/3] perf record: Propagate exit status of a command line workload

Hi Peter,

On Wed, 7 May 2014 19:35:32 +0200, Peter Zijlstra wrote:
> On Wed, May 07, 2014 at 07:19:14PM +0200, Stephane Eranian wrote:
>> > $ while :; do ./foo /bin/sleep 5 ; done
>> >
>> > and try and break out using ^C
>> >
>> What I usually do here is hit ^Z, then kill the job.
>> But I agree it would be nicer to handle this case automatically.
>
> So that used to work. And note that if you take out the signal(SIGINT,
> SIG_IGN) from the proglet, it will actually propagate the SIGINT and
> work as expected.
>
> So its only because perf handles SIGINT -- to be able to finish the
> stat/data record, that it doesn't. Which is why I propagated the signal
> the child got killed with.

Ah, okay.  But just propagating saved signal looks not enough since it's
overwritten by SIGCHLD as child exited.  I'll resend v5 soon.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/