linux-kernel - Re: [PATCH 2/3] ARM: shmobile: r8a7740 dtsi: Add Ethernet support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 08 May 2014 17:14:40 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
CC:	Geert Uytterhoeven <geert+renesas@...der.be>,
	Simon Horman <horms@...ge.net.au>,
	Magnus Damm <magnus.damm@...il.com>,
	Bastian Hecht <hechtb+renesas@...il.com>,
	Linux-sh list <linux-sh@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] ARM: shmobile: r8a7740 dtsi: Add Ethernet support

On 05/08/2014 05:06 PM, Geert Uytterhoeven wrote:

>>> +       ether: ethernet@...00000 {

>>     Are you really going to refer to this node somewhere, using its label?

> Yes, from r8a7740-armadillo800eva-reference.dts

    Ah, I completely forgot that there should be a board specific part of the 
node. Sorry.

>>> +               compatible = "renesas,gether-r8a7740";
>>> +               reg = <0xe9a00000 0x800>,
>>> +                     <0xe9a01800 0x800>;
>>> +               interrupt-parent = <&gic>;
>>> +               interrupts = <0 110 IRQ_TYPE_LEVEL_HIGH>;
>>> +               /* clocks = <&mstp3_clks R8A7740_CLK_GETHER>; */

>>     This property is mandatory, according to the bindings.

> Indeed, but you cannot put anything there until the platform has CCF, as
> mstp3_clks doesn't exist yet.

    Yes, that was the main obstacle to accepting those bindings sooner. This 
patch therefore seems somewhat premature.

> Gr{oetje,eeting}s,
>                          Geert

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/