linux-kernel - Re: [PATCH] Input: Introduce the use of the managed version of kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140508160419.GB11672@core.coreip.homeip.net>
Date:	Thu, 8 May 2014 09:04:19 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Himangi Saraogi <himangi774@...il.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	julia.lawall@...6.fr
Subject: Re: [PATCH] Input: Introduce the use of the managed version of
 kzalloc

Hi Himangi,

On Wed, May 07, 2014 at 10:16:38AM +0530, Himangi Saraogi wrote:
> This patch moves data allocated using kzalloc to managed data allocated
> using devm_kzalloc and cleans now unnecessary kfrees in probe and remove
> functions.

I prefer not to mix managed and unmanaged resources in one driver. I.e.
either all (or most) resources are managed or they are all unmanaged,
otherwise it is really hard to track which one should be freed and
which will be freed automatically.

In this very simple driver I do not see converting only memory
allocation to devm as bringing clear benefit,

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/