linux-kernel - Re: [PATCH 2/3] ARM: shmobile: r8a7740 dtsi: Add Ethernet support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <536BD280.9070808@cogentembedded.com>
Date:	Thu, 08 May 2014 22:52:48 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
CC:	Geert Uytterhoeven <geert+renesas@...der.be>,
	Simon Horman <horms@...ge.net.au>,
	Magnus Damm <magnus.damm@...il.com>,
	Bastian Hecht <hechtb+renesas@...il.com>,
	Linux-sh list <linux-sh@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] ARM: shmobile: r8a7740 dtsi: Add Ethernet support

On 05/08/2014 10:46 PM, Geert Uytterhoeven wrote:

>>>>>>> +               /* clocks = <&mstp3_clks R8A7740_CLK_GETHER>; */

>>>>>>       This property is mandatory, according to the bindings.

>>>>> Indeed, but you cannot put anything there until the platform has CCF, as
>>>>> mstp3_clks doesn't exist yet.

>>>>      Yes, that was the main obstacle to accepting those bindings sooner.
>>>> This patch therefore seems somewhat premature.

>>> My main objective is to provide working Ethernet support for Armadillo
>>> reference now.

>>     Mine was the same (but for BOCK-W board) but DT people didn't give a
>> damn. :-) So there's still no Ethernet support in BOCK-W DT.

> Yes there is: ethernet@...00000.

    That's for an on-board SMSC911x, not for sh_eth.

>>> The DTS already has other nodes without "clocks" properties.

>>     It means not everybody submitting the bindings had the same bad luck as me. :-)

> I think we have to be pragmatic here. The clocks properties will be added to
> the dtsi as soon as we have CCF support.

    I'd agree, so if there's no objections from DT people, I won't object anymore.

> Gr{oetje,eeting}s,
>                          Geert

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/