linux-kernel - Re: [PATCH] blk-mq: initialize struct request fields individually

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <536BEEB4.4000404@fb.com>
Date:	Thu, 8 May 2014 14:53:08 -0600
From:	Jens Axboe <axboe@...com>
To:	Christoph Hellwig <hch@....de>
CC:	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] blk-mq: initialize struct request fields individually

On 05/06/2014 04:12 AM, Christoph Hellwig wrote:
> This allows us to avoid a non-atomic memset over ->atomic_flags as well
> as killing lots of duplicate initializations.

I had an earlier variant of this as well, they are quite a few fields we
can neglect to initialize. But I think this is a safe start, however,
and we can always optimize it on top of it. Perhaps even start to
separate struct request a bit, so we can safely memset parts of it easily.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/