linux-kernel - Re: [PATCH 1/3] staging: cxt1e1: Fix no spaces at the start of a line in musycc.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140509075904.GJ26890@mwanda>
Date:	Fri, 9 May 2014 10:59:05 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Daeseok Youn <daeseok.youn@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	nandu.hgowda@...il.com, sachin.kamat@...aro.org,
	peter.p.waskiewicz.jr@...el.com, linux-kernel@...r.kernel.org,
	himangi774@...il.com, fempsci@...il.com
Subject: Re: [PATCH 1/3] staging: cxt1e1: Fix no spaces at the start of a
 line in musycc.c

On Fri, May 09, 2014 at 10:38:43AM +0900, Daeseok Youn wrote:
> clean up checkpatch.pl warning:
>  WARNING: please no spaces at the start of a line in
> 
> Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>
> ---
> This patch includes cleanup for fixing line length.
> 

This patch is super hard to review.  Your "line length" fixes include
moving variable declarations around, deleting comments, getting rid of
nonsense curly braces.  Those are all great but the patch is over a
thousand lines long and it's difficult to review.

If you just change spaces to tabs, that takes me 5 seconds to review
because I have scripts and email macros to do that.

If you just delete the #if 0 blocks that also is easy to review in a
single patch.

Just delete all the code that depends on #ifdef RLD_DUMP_BUFDATA because
that stuff is never set.

Please break this up into smaller patches and also write a better
changelog.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/