| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-id: <536C8E90.6030607@samsung.com>
Date: Fri, 09 May 2014 17:15:12 +0900
From: Chanwoo Choi <cw00.choi@...sung.com>
To: Tomasz Figa <t.figa@...sung.com>
Cc: Tomasz Figa <tomasz.figa@...il.com>, kgene.kim@...sung.com,
linux-kernel@...r.kernel.org, linux@....linux.org.uk,
ben-linux@...ff.org, arnd@...db.de, olof@...om.net,
marc.zyngier@....com, thomas.abraham@...aro.org,
kyungmin.park@...sung.com, inki.dae@...sung.com,
sw0312.kim@...sung.com, hyunhee.kim@...sung.com,
yj44.cho@...sung.com, chanho61.park@...sung.com,
sajjan.linux@...il.com, tushar.behera@...aro.org,
sachin.kamat@...aro.org, linux-samsung-soc@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
Jaehoon Chung <jh80.chung@...sung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
Rob Herring <robh+dt@...nel.org>,
Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>
Subject: Re: [PATCHv4 7/7] ARM: dts: Add device tree sources for Exynos3250
Hi Tomasz,
On 05/09/2014 05:01 PM, Tomasz Figa wrote:
> On 09.05.2014 08:49, Chanwoo Choi wrote:
>> Hi Tomasz,
>>
>> On 04/26/2014 08:38 PM, Tomasz Figa wrote:
>>> On 26.04.2014 02:51, Tomasz Figa wrote:
>>>> Hi Chanwoo,
>>>>
>>>> On 25.04.2014 03:16, Chanwoo Choi wrote:
>>>>> From: Tomasz Figa <t.figa@...sung.com>
>>>>>
>>>>> This patch add new exynos3250.dtsi to support Exynos3250 SoC based on
>>>>> Cortex-A7
>>>>> dual core and includes following dt nodes:
>>>>>
>>>>> - GIC interrupt controller
>>>>> - Pinctrl to control GPIOs
>>>>> - Clock controller
>>>>> - CPU information (Cortex-A7 dual core)
>>>>> - UART to support serial port
>>>>> - MCT (Multi Core Timer)
>>>>> - ADC (Analog Digital Converter)
>>>>> - I2C/SPI bus
>>>>> - Power domain
>>>>> - PMU (Performance Monitoring Unit)
>>>>> - MSHC (Mobile Storage Host Controller)
>>>>> - PWM (Pluse Width Modulation)
>>>>> - AMBA bus
>>>>>
>>>>> Signed-off-by: Tomasz Figa <t.figa@...sung.com>
>>>>> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
>>>>> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
>>>>> Signed-off-by: Inki Dae <inki.dae@...sung.com>
>>>>> Signed-off-by: Hyunhee Kim <hyunhee.kim@...sung.com>
>>>>> Signed-off-by: Jaehoon Chung <jh80.chung@...sung.com>
>>>>> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
>>>>> Cc: Ben Dooks <ben-linux@...ff.org>
>>>>> Cc: Kukjin Kim <kgene.kim@...sung.com>
>>>>> Cc: Rob Herring <robh+dt@...nel.org>
>>>>> Cc: Pawel Moll <pawel.moll@....com>
>>>>> Cc: Mark Rutland <mark.rutland@....com>
>>>>> Cc: Ian Campbell <ijc+devicetree@...lion.org.uk>
>>>>> Cc: Kumar Gala <galak@...eaurora.org>
>>>>> Cc: Russell King <linux@....linux.org.uk>
>>>>> Cc: devicetree@...r.kernel.org
>>>>> ---
>>>>> arch/arm/boot/dts/exynos3250-pinctrl.dtsi | 477 +++++++++++++++
>>>>> arch/arm/boot/dts/exynos3250.dtsi | 405 +++++++++++++
>>>>> arch/arm/boot/dts/exynos4212-tizenw.dts | 926
>>>>> ++++++++++++++++++++++++++++++
>>>>> 3 files changed, 1808 insertions(+)
>>>>> create mode 100644 arch/arm/boot/dts/exynos3250-pinctrl.dtsi
>>>>> create mode 100644 arch/arm/boot/dts/exynos3250.dtsi
>>>>> create mode 100644 arch/arm/boot/dts/exynos4212-tizenw.dts
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/exynos3250-pinctrl.dtsi
>>>>> b/arch/arm/boot/dts/exynos3250-pinctrl.dtsi
>>>>> new file mode 100644
>>>>> index 0000000..976490b
>>>>> --- /dev/null
>>>>> +++ b/arch/arm/boot/dts/exynos3250-pinctrl.dtsi
>>>>> @@ -0,0 +1,477 @@
>>>>> +/*
>>>>> + * Samsung's Exynos3250 SoCs pin-mux and pin-config device tree source
>>>>> + *
>>>>> + * Copyright (c) 2014 Samsung Electronics Co., Ltd.
>>>>> + * http://www.samsung.com
>>>>> + *
>>>>> + * Samsung's Exynos3250 SoCs pin-mux and pin-config optiosn are
>>>>> listed as device
>>>>> + * tree nodes are listed in this file.
>>>>> + *
>>>>> + * This program is free software; you can redistribute it and/or modify
>>>>> + * it under the terms of the GNU General Public License version 2 as
>>>>> + * published by the Free Software Foundation.
>>>>> +*/
>>>>> +
>>>>> +/ {
>>>>> + pinctrl@...00000 {
>>>>
>>>> Could you use references instead of re-specifying the whole tree
>>>> hierarchy in every file a node is used?
>>>>
>>>> Instead of
>>>>
>>>> / {
>>>> pinctrl@...00000 {
>>>>
>>>> };
>>>> };
>>>>
>>>> one may simply use
>>>>
>>>> &pinctrl_0 {
>>>>
>>>> };
>>>>
>>>> You might just need to change the location of #include
>>>> "exynos3250-pinctrl.dtsi" from top of exynos3250.dtsi to bottom of it.
>>>
>>> Oh, well, you also should move all nodes of on-SoC devices under a simple-bus node called soc. You can see the patch adding dts file for Exynos5260 for an example [1].
>>>
>>> [1] http://thread.gmane.org/gmane.linux.kernel.samsung-soc/29360/focus=29361
>>
>>
>> OK, I'll move nodes dependent on SoC under 'soc' dt node as example patch[1] except for 'amba-bus' dt node.
>
> I don't see any reason why amba-bus node shouldn't be under soc node as
> well. Any on-chip devices should be.
I didn't understand the correct meaning of 'simple-bus'.
OK, I'll move 'amba-bus' dt node under 'soc' dt node.
Best Regards,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists