linux-kernel - Re: [PATCH] backlight: gpio-backlight: Fix warning when the GPIO is on a I2C chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZV647fx5j+a8ds_1eHffwnUijvX7qodH7LgJtYkqvvEw@mail.gmail.com>
Date:	Fri, 9 May 2014 11:06:45 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	Tony Lindgren <tony@...mide.com>, Lee Jones <lee.jones@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-fbdev@...r.kernel.org" <linux-fbdev@...r.kernel.org>,
	Linux-OMAP <linux-omap@...r.kernel.org>,
	Bryan Wu <cooloney@...il.com>,
	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Tomi Valkeinen <tomi.valkeinen@...com>,
	Alexandre Courbot <gnurou@...il.com>,
	Russell King <linux@....linux.org.uk>
Subject: Re: [PATCH] backlight: gpio-backlight: Fix warning when the GPIO is
 on a I2C chip

On Fri, May 9, 2014 at 5:42 AM, Jingoo Han <jg1.han@...sung.com> wrote:

> Linus Walleij,
> Is there any reason to keep these two functions such as
> gpiod_set_raw_value_cansleep() and gpiod_set_raw_value()?

Yes, the former can *not* be called from interrupt context,
and thus erroneous usage can be detected with runtime checks.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/