linux-kernel - Re: [PATCH] usb: gadget: atmel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <536CA977.7080404@atmel.com>
Date:	Fri, 9 May 2014 12:09:59 +0200
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Felipe Balbi <balbi@...com>
CC:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>
Subject: Re: [PATCH] usb: gadget: atmel_usba: always test udc->driver

On 06/05/2014 17:16, Alexandre Belloni :
> Found using smatch: drivers/usb/gadget/atmel_usba_udc.c:1689 usba_udc_irq()
> error: we previously assumed 'udc->driver' could be null (see line 1636)
> 
> Always test udc->driver before using its members.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>


Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>

Thanks,

> ---
>  drivers/usb/gadget/atmel_usba_udc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/atmel_usba_udc.c b/drivers/usb/gadget/atmel_usba_udc.c
> index 9f65324f9ae0..76023ce449a3 100644
> --- a/drivers/usb/gadget/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/atmel_usba_udc.c
> @@ -1686,7 +1686,7 @@ static irqreturn_t usba_udc_irq(int irq, void *devid)
>  		reset_all_endpoints(udc);
>  
>  		if (udc->gadget.speed != USB_SPEED_UNKNOWN
> -				&& udc->driver->disconnect) {
> +				&& udc->driver && udc->driver->disconnect) {
>  			udc->gadget.speed = USB_SPEED_UNKNOWN;
>  			spin_unlock(&udc->lock);
>  			udc->driver->disconnect(&udc->gadget);
> 


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/