linux-kernel - Re: [PATCH] mfd: syscon: Include linux/err.h to fix build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140509111513.GT5767@lee--X1>
Date:	Fri, 9 May 2014 12:15:13 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Tushar Behera <tushar.behera@...aro.org>
Cc:	linux-kernel@...r.kernel.org, sameo@...ux.intel.com,
	peter.chen@...escale.com
Subject: Re: [PATCH] mfd: syscon: Include linux/err.h to fix build error

On Fri, 09 May 2014, Tushar Behera wrote:

> commit df73de9b0d412 ("mfd: syscon: Return -ENOSYS if CONFIG_MFD_SYSCON
> is not enabled") introduced fallbacks for APIs, but missed out on adding
> the header file. This would work only if linux/err.h is also included
> in the source code from where this file is included. It would be better
> to include linux/err.h in file to remove possible build errors.
> 
> Without this patch, we get following and similar build errors if this
> header file is included in some source file and CONFIG_MFD_SYSCON is
> not enabled.
> 
> include/linux/mfd/syscon.h: In function ‘syscon_node_to_regmap’:
> include/linux/mfd/syscon.h:30:2: error: implicit declaration of function ‘ERR_PTR’ [-Werror=implicit-function-declaration]
>   return ERR_PTR(-ENOSYS);
>   ^
> include/linux/mfd/syscon.h:30:18: error: ‘ENOSYS’ undeclared (first use in this function)
>   return ERR_PTR(-ENOSYS);
>                   ^
> 
> Signed-off-by: Tushar Behera <tushar.behera@...aro.org>
> ---
>  include/linux/mfd/syscon.h |    2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/