linux-kernel - Re: [PATCH] spi/pxa2xx: Prevent DMA from transferring too many bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140509112712.GL12304@sirena.org.uk>
Date:	Fri, 9 May 2014 12:27:12 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org, Eric Miao <eric.y.miao@...il.com>,
	Russell King <linux@....linux.org.uk>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	Chiau Ee Chew <chiau.ee.chew@...el.com>,
	Hock Leong Kweh <hock.leong.kweh@...el.com>
Subject: Re: [PATCH] spi/pxa2xx: Prevent DMA from transferring too many bytes

On Fri, May 09, 2014 at 02:21:05PM +0300, Mika Westerberg wrote:
> On Fri, May 09, 2014 at 11:33:15AM +0100, Mark Brown wrote:

> > Is this definitely the case for all of the IPs using this driver?  It
> > seems like something which might have been present in actual PXA
> > implemenetations but got fixed in later revisons used with x86.  Equally
> > well the current code is clearly broken either way so I'm not sure that
> > problems with older systems should be a barrier to merging the patch but
> > it seems better to check.

> This code came with x86 LPSS implementation originally. The PXA one,
> which lives in a different file (spi-pxa2xx-pxadma.c) didn't have any
> such checks AFAIK.

OK, that should be fine then.  The PXA platforms should be being
converted over to use this file as part of the dmaengine transition on
that platform so we can't assume it's Intel specific even though it was
originally written for x86.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)