linux-kernel - Re: [PATCH 2/5] staging: cxt1e1: remove dead code in musycc.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHb8M2AopFJGhgZOu_hbn2YWvMgeuFz2zK2uYo4Fnt6kACKSOg@mail.gmail.com>
Date:	Fri, 9 May 2014 23:09:35 +0900
From:	DaeSeok Youn <daeseok.youn@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	gregkh@...uxfoundation.org, himangi774@...il.com,
	sachin.kamat@...aro.org, fempsci@...il.com, nandu.hgowda@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] staging: cxt1e1: remove dead code in musycc.c

2014-05-09 19:51 GMT+09:00, Dan Carpenter <dan.carpenter@...cle.com>:
> On Fri, May 09, 2014 at 07:06:06PM +0900, Daeseok Youn wrote:
>> Removes "#if 0" blocks.
>>
>> Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>
>> ---
>> Dan,
>>  I decided to leave musycc_dump_rxbuffer_ring(ch, 0) which is commented
>>  out and make a block as "RLD_DEBUG". Because i think this block need to
>> debug
>>  with define "RLD_DEBUG". If I am wrong, let me know.
>>
>
> This change should maybe have been in a separate patch.  It's a border
> line thing.  But definitely, it should have been mentioned in the
> changelog.
>
> Btw, you can use `git citool` to add or remove lines from a
> commit.  Highlight and right click on the lines you want to add or
> remove.
Thanks for the tip. I used "git add -p" after "git rebase" and "git
reset HEAD" for
spliting a patch.
But I have a question, Do I have to resend rest of patches after
spliting this patch?
In this case, 2/5 is splited to two, it doesn't need to rebase but
numbering of patches are changed.

>
> I don't really care either way if you keep it or delete it.
Ok. I will leave this.

Thanks for review.

Regards,
Daeseok Youn

>
> regards,
> dan carpenter
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/