linux-kernel - Re: [PATCH 2/2] sched: Fix next_balance logic in rebalance_domains() and idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1399656540.2169.20.camel@j-VirtualBox>
Date:	Fri, 09 May 2014 10:29:00 -0700
From:	Jason Low <jason.low2@...com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
	daniel.lezcano@...aro.org, alex.shi@...aro.org,
	preeti@...ux.vnet.ibm.com, efault@....de,
	vincent.guittot@...aro.org, morten.rasmussen@....com, aswin@...com,
	jason.low2@...com
Subject: Re: [PATCH 2/2] sched: Fix next_balance logic in
 rebalance_domains() and idle_balance()

On Fri, 2014-05-09 at 11:08 +0200, Peter Zijlstra wrote:
> On Thu, May 08, 2014 at 05:49:22PM -0700, Jason Low wrote:
> > On Thu, 2014-05-08 at 15:14 -0700, Jason Low wrote:
> > > Hi Ingo, Peter,
> > > 
> > > Were there NULL domains on the test system? If so, I think we can
> > > address the problem by doing update_next_balance() only if the below
> > > rcu_dereference_check_sched_domain() returns a non-null domain.
> > 
> > Also, below is a patch which has the change:
> > 
> 
> Thanks, and yes, NULL domains are a perfectly normal thing to have
> (though not common on normal boot paths).

Okay. Likewise, on my test machine, I offline all but 1 CPU
in order to try reproducing the issue.

Thanks,
Jason

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/