linux-kernel - Re: [PATCH] drivers: staging: ft1000: Improve coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 09 May 2014 13:24:40 -0700
From:	Joe Perches <joe@...ches.com>
To:	Artem Fetishev <wwctrsrx@...il.com>
Cc:	marek.belisko@...il.com, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: staging: ft1000: Improve coding style

On Sat, 2014-05-10 at 09:53 +0300, Artem Fetishev wrote:
> Improvements include:
>  - Lines over 80 characters;
>  - Use pr_info() instead printk(KERN_INFO);
>  - Removal of typedefs;
>  - Indentation.
>  - Fix IOCTL_FT1000_* marcos:
>    - Add closing brackets;
>    - remove sizeof (_IOR and _IOW macro can accept types);
>    - replace _IOW which size of 0 (the last arg) with _IO.
>    - Actually these macros are not used anywhere and might be removed.

Hello Artem.

All of these are nice little fixes, but combined,
they are difficult to review.

Could you please separate them into multiple patches,
one per line item entry?

Maybe reorder them too doing the indentation fix
first and leaving the 80 column changes until last.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/