linux-kernel - Re: [PATCH] checkpatch: Warn on #defines ending in semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1399672788.2912.32.camel@joe-AO725>
Date:	Fri, 09 May 2014 14:59:48 -0700
From:	Joe Perches <joe@...ches.com>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Borislav Petkov <bp@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andres Freund <andres@...razel.de>, x86@...nel.org,
	linux-kernel@...r.kernel.org,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Ingo Molnar <mingo@...hat.com>,
	Andy Whitcroft <apw@...onical.com>
Subject: Re: [PATCH] checkpatch: Warn on #defines ending in semicolon

On Fri, 2014-05-09 at 23:47 +0200, Thomas Gleixner wrote:
> On Fri, 9 May 2014, Joe Perches wrote:
> 
> > Using a #define ending in a semicolon is poor style
> 
> It's not poor style it's simply a bug. Just because it 
> 
> > can lead to unexpected code paths being executed.

I think it's still a (bad) style issue.

I remember a discussion with a developer that
wanted all macros to end in a semicolon so he
could write COBOL like C.

ick.

cheers, Joe


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/