linux-kernel - Re: [PATCH 1/6] usb: host: ehci-exynos: Use devm_ioremap_resource instead of devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1399716396.580639659@f244.i.mail.ru>
Date:	Sat, 10 May 2014 14:06:36 +0400
From:	Alexander Shiyan <shc_work@...l.ru>
To:	Vivek Gautam <gautam.vivek@...sung.com>
Cc:	linux-samsung-soc@...r.kernel.org, swarren@...dotorg.org,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	kgene.kim@...sung.com, stern@...land.harvard.edu,
	linux-tegra@...r.kernel.org, thierry.reding@...il.com,
	linux-arm-kernel@...ts.infradead.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH 1/6] usb: host: ehci-exynos: Use devm_ioremap_resource instead of devm_ioremap

Sat, 10 May 2014 15:26:58 +0530 от Vivek Gautam <gautam.vivek@...sung.com>:
> Using devm_ioremap_resource() API should actually be preferred over
> devm_ioremap(), since the former request the mem region first and then
> gives back the ioremap'ed memory pointer.
> devm_ioremap_resource() calls request_mem_region(), therby preventing
> other drivers to make any overlapping call to the same region.
> 
> Signed-off-by: Vivek Gautam <gautam.vivek@...sung.com>
> ---
>  drivers/usb/host/ehci-exynos.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c
> index 7f425ac..bccb6f1 100644
> --- a/drivers/usb/host/ehci-exynos.c
> +++ b/drivers/usb/host/ehci-exynos.c
> @@ -135,9 +135,8 @@ skip_phy:
>  
>  	hcd->rsrc_start = res->start;
>  	hcd->rsrc_len = resource_size(res);
> -	hcd->regs = devm_ioremap(&pdev->dev, res->start, hcd->rsrc_len);
> +	hcd->regs = devm_ioremap_resource(&pdev->dev, res);
>  	if (!hcd->regs) {
> -		dev_err(&pdev->dev, "Failed to remap I/O memory\n");
>  		err = -ENOMEM;
>  		goto fail_io;
>  	}

You should check this as:

if (IS_ERR(hcd->regs)) {
err = PTR_ERR(hcd->regs);
...

Same in other patches in this series.

---