linux-kernel - Re: [PATCH v2 0/6] usb: host: Cleanup for ioremap'ing hcd memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 10 May 2014 18:25:56 +0400
From:	Alexander Shiyan <shc_work@...l.ru>
To:	Vivek Gautam <gautam.vivek@...sung.com>
Cc:	linux-samsung-soc@...r.kernel.org, swarren@...dotorg.org,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	kgene.kim@...sung.com, stern@...land.harvard.edu,
	linux-tegra@...r.kernel.org, thierry.reding@...il.com,
	linux-arm-kernel@...ts.infradead.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v2 0/6] usb: host: Cleanup for ioremap'ing hcd memory

Sat, 10 May 2014 17:30:04 +0530 от Vivek Gautam <gautam.vivek@...sung.com>:
> Based on 'usb-next' branch of Greg's usb tree.
> 
> devm_ioremap_resource() API is advantageous over devm_ioremap()
> and should therefore be preferred to request any ioremap'ed address
> for hcd.
> 
> Changes from v1:
>  - Changed the way returned pointer is checked for error value
>    as pointed out in the review comment in the mailing list.

hcd->rsrc_len field can be removed entirely, since I cannot find any reason
how this filed can be used in the drivers now.
This is of course should be in an another series. This one looks good.

---