linux-kernel - Re: [PATCH] lib/crc7: Shift crc7() output left 1 bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	11 May 2014 05:16:07 -0400
From:	"George Spelvin" <linux@...izon.com>
To:	linux@...izon.com, pavel@....cz
Cc:	arik@...ery.com, coelho@...com, david.gnedt@...izone.at,
	eliad@...ery.com, jan.nikitenko@...il.com,
	laurent.pinchart+renesas@...asonboard.com,
	linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
	linville@...driver.com, luca@...lho.fi, tony@...mide.com
Subject: Re: [PATCH] lib/crc7: Shift crc7() output left 1 bit

> Looks good, but should not function name change when functionality got
> completely different?

I couldn't think of one.  Can you?

I suppose adding a _be (big-endian) suffix would be consistent.
Is that okay with you?

To do it properly, I have to rename all of:

crc7_syndrome_table[]
crc7_byte()
crc7()

even though the third is the only (in-tree) user of the first two.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/