| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20140511103602.GC32609@xo-6d-61-c0.localdomain> Date: Sun, 11 May 2014 12:36:02 +0200 From: Pavel Machek <pavel@....cz> To: George Spelvin <linux@...izon.com> Cc: arik@...ery.com, david.gnedt@...izone.at, eliad@...ery.com, jan.nikitenko@...il.com, laurent.pinchart+renesas@...asonboard.com, linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org, linux-spi@...r.kernel.org, linux-wireless@...r.kernel.org, linville@...driver.com, luca@...lho.fi, tony@...mide.com Subject: Re: [PATCH 3/3] drivers/net/wireless/ti/wl*/spi.c: Simplify CRC computation On Sun 2014-05-11 06:07:43, George Spelvin wrote: > These devices require commands stored in buffers in an odd order, > different from that in which the CRC is computed. > > Rather than make two copies of the commands in two different orders, > form the commands in logical (CRC) order, append the CRC, then byte-swap > in place to the desired order. > > The old code worked fine, I'm just scratching an "ugh, that's ugly" > itch. > > Signed-off-by: George Spelvin <linux@...izon.com> Reviewed-by: Pavel Machek <pavel@....cz> -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists