lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 11 May 2014 20:14:00 +0530 From: Vivek Gautam <gautam.vivek@...sung.com> To: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> Cc: Linux USB Mailing List <linux-usb@...r.kernel.org>, "linux-samsung-soc@...r.kernel.org" <linux-samsung-soc@...r.kernel.org>, linux-tegra@...r.kernel.org, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, Greg KH <gregkh@...uxfoundation.org>, Alan Stern <stern@...land.harvard.edu>, Stephen Warren <swarren@...dotorg.org>, Kukjin Kim <kgene.kim@...sung.com>, thierry.reding@...il.com Subject: Re: [PATCH 5/6] usb: host: ehci-tegra: Use devm_ioremap_resource instead of devm_ioremap Hi, On Sun, May 11, 2014 at 1:13 AM, Sergei Shtylyov <sergei.shtylyov@...entembedded.com> wrote: > Hello. > > > On 05/10/2014 01:57 PM, Vivek Gautam wrote: > >> Using devm_ioremap_resource() API should actually be preferred over >> devm_ioremap(), since the former request the mem region first and then >> gives back the ioremap'ed memory pointer. >> devm_ioremap_resource() calls request_mem_region(), therby preventing >> other drivers to make any overlapping call to the same region. > > >> Signed-off-by: Vivek Gautam <gautam.vivek@...sung.com> >> --- >> drivers/usb/host/ehci-tegra.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) > > >> diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c >> index 572634c..ccc6433 100644 >> --- a/drivers/usb/host/ehci-tegra.c >> +++ b/drivers/usb/host/ehci-tegra.c >> @@ -411,9 +411,8 @@ static int tegra_ehci_probe(struct platform_device >> *pdev) >> } >> hcd->rsrc_start = res->start; >> hcd->rsrc_len = resource_size(res); >> - hcd->regs = devm_ioremap(&pdev->dev, res->start, >> resource_size(res)); >> + hcd->regs = devm_ioremap_resource(&pdev->dev, res); >> if (!hcd->regs) { > > > This has to be changed as well as devm_ioremap_resource() returns error, > not NULL. Have already updated in the v2 version of this patch, and others in the series. > > >> - dev_err(&pdev->dev, "Failed to remap I/O memory\n"); >> err = -ENOMEM; > > > This needs to be changed as well, to pass up the error code > devm_ioremap_resource() returned. ditoo -- Best Regards Vivek Gautam Samsung R&D Institute, Bangalore India -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists