linux-kernel - Re: [lm-sensors] [PATCH] drivers/hwmon/emc1403.c: add support for emc1412

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5370300A.8070102@roeck-us.net>
Date:	Sun, 11 May 2014 19:20:58 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Josef Gajdusek <atx@....name>, jdelvare@...e.de
CC:	linux-kernel@...r.kernel.org, lm-sensors@...sensors.org
Subject: Re: [lm-sensors] [PATCH] drivers/hwmon/emc1403.c: add support for
 emc1412

On 05/11/2014 03:40 PM, Guenter Roeck wrote:
[ ... ]

>>
>>       id = i2c_smbus_read_byte_data(client, THERMAL_REVISION_REG);
>> -    if (id != 0x01)
>> +    if (id != 0x01 && id != 0x04) {
>>           return -ENODEV;
>
> This should be a separate patch, as it applies to emc1403/emc1404 as well,
> so we can backport it into -stable.
>

Also, the chip datasheet suggests that chip revision 3 exists as well.
Given that, I would suggest to replace the revision number check with
something like
	if (id < 0x01 || id > 0x04)
		return -ENODEV;

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/