linux-kernel - Re: [PATCH V4 2/2] fs/ext4/fsync.c: generic_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140512072404.d95d59e467579e79f20ca2f9@skynet.be>
Date:	Mon, 12 May 2014 07:24:04 +0200
From:	Fabian Frederick <fabf@...net.be>
To:	Ming Lei <tom.leiming@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>, jack <jack@...e.cz>,
	hch <hch@...radead.org>, Viro <viro@...iv.linux.org.uk>,
	tytso <tytso@....edu>, akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH V4 2/2] fs/ext4/fsync.c: generic_file_fsync call based
 on barrier flag

On Mon, 12 May 2014 11:24:26 +0800
Ming Lei <tom.leiming@...il.com> wrote:

> On Sun, May 11, 2014 at 1:06 AM, Fabian Frederick <fabf@...net.be> wrote:
> > generic_file_fsync has been updated to issue a flush for
> > older filesystems.
> >
> > This patch tests for barrier flag in ext4 mount flags
> > and calls the right function.
> >
> > Suggested-by: Jan Kara <jack@...e.cz>
> > Suggested-by: Christoph Hellwig <hch@...radead.org>
> > Cc: Jan Kara <jack@...e.cz>
> > Cc: Christoph Hellwig <hch@...radead.org>
> > Cc: Alexander Viro <viro@...iv.linux.org.uk>
> > Cc: "Theodore Ts'o" <tytso@....edu>
> > Cc: Andrew Morton <akpm@...ux-foundation.org>
> > Signed-off-by: Fabian Frederick <fabf@...net.be>
> > ---
> >  fs/ext4/fsync.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c
> > index a8bc47f..fa82c0a 100644
> > --- a/fs/ext4/fsync.c
> > +++ b/fs/ext4/fsync.c
> > @@ -108,6 +108,10 @@ int ext4_sync_file(struct file *file, loff_t start, loff_t end, int datasync)
> >
> >         if (!journal) {
> >                 ret = generic_file_fsync(file, start, end, datasync);
> 
> Forget to remove above line?
Oops, of course ! Thanks a lot, I've sent a new version :)

Regards,
Fabian

> 
> > +               if (test_opt(inode->i_sb, BARRIER))
> > +                       ret = generic_file_fsync(file, start, end, datasync);
> > +               else
> > +                       ret = __generic_file_fsync(file, start, end, datasync);
> >                 if (!ret && !hlist_empty(&inode->i_dentry))
> >                         ret = ext4_sync_parent(inode);
> >                 goto out;
> 
> 
> 
> Thanks,
> -- 
> Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/