linux-kernel - Re: [PATCH] printk/of_serial: fix serial console cessation part way through boot.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdXQaOewxwe4UoiWj4KoT2Lybug2Spg4TzXd5g_Mfi-1Dg@mail.gmail.com>
Date:	Mon, 12 May 2014 11:33:17 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Stephen Chivers <schivers@....com>
Cc:	Jiri Slaby <jslaby@...e.cz>, Greg KH <gregkh@...uxfoundation.org>,
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	rob+dt@...nel.org, Grant Likely <grant.likely@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Chris Proctor <cproctor@....com>, linux-serial@...r.kernel.org
Subject: Re: [PATCH] printk/of_serial: fix serial console cessation part way
 through boot.

Hi Stephen,

On Sat, May 10, 2014 at 7:37 AM, Stephen Chivers <schivers@....com> wrote:
> Commit 5f5c9ae56c38942623f69c3e6dc6ec78e4da2076
> "serial_core: Unregister console in uart_remove_one_port()"
> fixed a crash where a serial port was removed but
> not deregistered as a console.
>
> There is a side effect of that commit for platforms having serial consoles
> and of_serial configured (CONFIG_SERIAL_OF_PLATFORM). The serial console
> is disabled midway through the boot process.
>
> This cessation of the serial console affects PowerPC computers
> such as the MVME5100 and SAM440EP.
>
> The sequence is:
>
>         bootconsole [udbg0] enabled
>         ....
>         serial8250/16550 driver initialises and registers its UARTS,
>         one of these is the serial console.
>         console [ttyS0] enabled
>         ....
>         of_serial probes "platform" devices, registering them as it goes.
>         One of these is the serial console.
>         console [ttyS0] disabled.
>
> The disabling of the serial console is due to:
>
>         a.  unregister_console in printk not clearing the
>             CONS_ENABLED bit in the console flags,
>             even though it has announced that the console is disabled; and

This part re-attaches the serial console on unbind/bind with the sh-sci driver,
too, which didn't work before. Cool, thanks!

>         b.  of_platform_serial_probe in of_serial not setting the port type
>             before it registers with serial8250_register_8250_port.

This part I couldn't test.

> This patch ensures that the serial console is re-enabled when of_serial
> registers a serial port that corresponds to the designated console.
>
> Signed-off-by: Stephen Chivers <schivers@....com>
> Tested-by: Stephen Chivers <schivers@....com>

Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org> [unregister_console]

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/