linux-kernel - Re: [PATCH 1/3] mm: add comment for __mod_zone_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1405121102170.17673@gentwo.org>
Date:	Mon, 12 May 2014 11:05:24 -0500 (CDT)
From:	Christoph Lameter <cl@...ux.com>
To:	Jianyu Zhan <nasa4836@...il.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Hugh Dickins <hughd@...gle.com>,
	Rik van Riel <riel@...hat.com>, Mel Gorman <mgorman@...e.de>,
	Zhang Yanfei <zhangyanfei@...fujitsu.com>,
	Andrea Arcangeli <aarcange@...hat.com>, fabf@...net.be,
	sasha.levin@...cle.com, oleg@...hat.com,
	Naoya Horiguchi <n-horiguchi@...jp.nec.com>,
	iamjoonsoo.kim@....com, kirill.shutemov@...ux.intel.com,
	Cyrill Gorcunov <gorcunov@...il.com>,
	dave.hansen@...ux.intel.com, toshi.kani@...com,
	paul.gortmaker@...driver.com, srivatsa.bhat@...ux.vnet.ibm.com,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] mm: add comment for __mod_zone_page_stat

On Mon, 12 May 2014, Jianyu Zhan wrote:

> This means they guarantee that even they are preemted the vm
> counter won't be modified incorrectly.  Because the counter is page-related
> (e.g., a new anon page added), and they are exclusively hold the pte lock.

But there are multiple pte locks for numerous page. Another process could
modify the counter because the pte lock for a different page was
available which would cause counter corruption.


> So, as you concludes in the other mail that __modd_zone_page_stat
> couldn't be used.
> in mlocked_vma_newpage, then what qualifies other call sites for using
> it, in the same situation?

Preemption should be off in those functions because a spinlock is being
held.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/